Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate Source and Parent if needed #821

Merged
merged 2 commits into from
May 21, 2020
Merged

Conversation

bitwiseman
Copy link
Member

@bitwiseman bitwiseman commented May 20, 2020

NOTE: this also addresses a bug in push events where the repository url is incorrect

Fixes #805
Fixes https://issues.jenkins-ci.org/browse/JENKINS-61924

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn clean compile locally. This may reformat your code, commit those changes.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

NOTE: this also addresses a bug in push events where the repository url is incorrect
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GHRepository.getSource() should not return null for a forked repository
1 participant