Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for fetching what teams are part of this team. #849

Merged
merged 6 commits into from
Jul 15, 2020

Conversation

alexanderkjall
Copy link

@alexanderkjall alexanderkjall commented Jun 17, 2020

Description

The call is to this endpoint https://developer.github.com/v3/teams/#list-child-teams-legacy

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn clean compile locally. This may reformat your code, commit those changes.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@alexanderkjall
Copy link
Author

I tried following the setup guide for writing tests, but without success, I got:

org.kohsuke.github.GHFileNotFoundException: http://localhost:35361/orgs/hub4j-test-org/teams/dummy-team {"message":"Not Found","documentation_url":"https://developer.github.com/v3/teams/#get-team-by-name"}

And didn't really understand why that happened.

@bitwiseman
Copy link
Member

@alexanderkjall
Please add a test. I can then help you refine it.

@bitwiseman
Copy link
Member

Also, please describe the steps you followed from the guide and the result from each step.

@alexanderkjall
Copy link
Author

The problem that I had was due to not being a part of the test organization, once I was added it worked without problem.

Copy link
Member

@bitwiseman bitwiseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexanderkjall
I removed getChildTeams() - it is extremely easy to call listChildTeams().toSet(). If you feel strongly otherwise, we can add it to the next release.

@bitwiseman bitwiseman merged commit 08bde72 into hub4j:master Jul 15, 2020
@alexanderkjall alexanderkjall deleted the add-support-for-child-teams branch July 16, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants