Implement deployment API support for ant-man and flash previews #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bitwiseman Tests are implemented and this is ready for review. One change that I wanted feedback on was the addition of a value field to the |
|
@bitwiseman friendly bump |
bitwiseman
requested changes
Nov 3, 2020
|
@bitwiseman Feedback addressed. |
marcoferrer
force-pushed
the
update-deployments-api
branch
from
0c6ddae
to
59b61cd
Compare
bitwiseman
approved these changes
Nov 25, 2020
| @@ -8,11 +8,23 @@ | |||
| * Indicates that the method/class/etc marked maps to GitHub API in the preview period. | |||
| * <p> | |||
| * These APIs are subject to change and not a part of the backward compatibility commitment. Always used in conjunction | |||
| * with 'deprecated' to raise awareness to clients. | |||
| * with 'deprecated' to raise awareness to clients. In addition, it's advised to update the targets documentation to | |||
| * signify that the deprecation is required until preview feature being used is promoted to stable. | |||
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previewsclass.GHDeploymentandGHDeploymentStatus.GHDeploymentBuilderandGHDeploymentStatusBuilder.GHDeploymentStatehas been updated to supportin_progress,queued, andinactive.GHDeploymentStatus.getTargetUrl()andGHDeploymentStatusBuilder.targetUrl()as@Deprecated.logUrl()where appropriateGithub Blog Posts For Previews Implemented
Before submitting a PR:
We love getting PRs, but we hate asking people for the same basic changes every time.
master. Create your PR from that branch.mvn clean compilelocally. This may reformat your code, commit those changes.mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.When creating a PR: