Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"target_url" for the payload of the status event #999

Merged
merged 2 commits into from
Dec 13, 2020

Conversation

tginiotis-at-work
Copy link
Contributor

Description

A commit status can have an optional link. After that status is added - the emitted event payload also contains that link.
This PR adds support for that link. It is defined in the documentation.

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than master. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn clean compile locally. This may reformat your code, commit those changes.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

@tginiotis-at-work tginiotis-at-work changed the title Targeturl for status "target_url" for the payload of the status event Dec 12, 2020
@bitwiseman bitwiseman merged commit 3819984 into hub4j:master Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants