refactor: apply suggestions, simplify code

hubtype · May 17, 2024 · 5fbd872 · 5fbd872
1 parent 80b82c4
commit 5fbd872
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 17 deletions.
diff --git a/packages/botonic-plugin-flow-builder/src/index.ts b/packages/botonic-plugin-flow-builder/src/index.ts
@@ -68,7 +68,7 @@ export default class BotonicPluginFlowBuilder implements Plugin {
     this.trackEvent = options.trackEvent
     this.getKnowledgeBaseResponse = options.getKnowledgeBaseResponse
     this.smartIntentsConfig = {
-      ...(options.smartIntentsConfig || {}),
+      ...options?.smartIntentsConfig,
       use_latest: jsonVersion === FlowBuilderJSONVersion.LATEST,
     }
     const customFunctions = options.customFunctions || {}

diff --git a/packages/botonic-plugin-flow-builder/src/user-input/smart-intent.ts b/packages/botonic-plugin-flow-builder/src/user-input/smart-intent.ts
@@ -11,26 +11,17 @@ export interface SmartIntentsInferenceParams {
   num_smart_intents_to_use?: number
 }
 export class SmartIntentsApi {
-  public cmsApi: FlowBuilderApi
-  public currentRequest: ActionRequest
-  public smartIntentsConfig: Partial<SmartIntentsInferenceParams>
-
   constructor(
-    cmsApi: FlowBuilderApi,
-    request: ActionRequest,
-    smartIntentsConfig: Partial<SmartIntentsInferenceParams>
-  ) {
-    this.currentRequest = request
-    this.cmsApi = cmsApi
-    this.smartIntentsConfig = smartIntentsConfig
-  }
+    public cmsApi: FlowBuilderApi,
+    public currentRequest: ActionRequest,
+    public smartIntentsConfig: Partial<SmartIntentsInferenceParams>
+  ) {}
 
   async getNodeByInput(): Promise<HtSmartIntentNode | undefined> {
-    if (!this.currentRequest.input.data) return undefined
     const smartIntentNodes = this.cmsApi.getSmartIntentNodes()
     if (!smartIntentNodes.length) return undefined
 
-    const params: SmartIntentsInferenceParams = {
+    const params = {
       bot_id: this.currentRequest.session.bot.id,
       text: this.currentRequest.input.data,
       ...this.smartIntentsConfig,

diff --git a/packages/botonic-plugin-flow-builder/tests/__mocks__/smart-intent.ts b/packages/botonic-plugin-flow-builder/tests/__mocks__/smart-intent.ts
@@ -11,6 +11,6 @@ export function mockSmartIntent(intentName?: string) {
 
   // Change the implementation of getInference
   getInferenceSpy.mockImplementation(async () => {
-    return intentName ? { data: { intent_name: intentName } } : undefined
+    return intentName ? { data: { smart_intent_title: intentName } } : undefined
   })
 }
diff --git a/packages/botonic-plugin-flow-builder/tests/smart-intent.test.ts b/packages/botonic-plugin-flow-builder/tests/smart-intent.test.ts
@@ -34,7 +34,6 @@ describe('Check the contents returned by the plugin when match a smart intent',
       request,
       flowBuilderPlugin
     )
-
     expect((contents[0] as FlowText).text).toBe(
       'Message explaining how to add a bag'
     )