-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger Button with notifications #2552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asastre
reviewed
Jul 4, 2023
…nd update it in webchatReducer
…d defaultValue in getThemeProperty
Iru89
force-pushed
the
trigger-notifications
branch
from
July 7, 2023 08:37
87fb586
to
804b5fd
Compare
asastre
approved these changes
Jul 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Very nice and clean refactor!! 🚀
AinaVendrell
approved these changes
Jul 7, 2023
check the test that are failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Be able to show in the trigger button the number of received and unread messages. I consider a message unread when I receive it and the webchat is closed.
Context
In local is not working well as the message sets the ack to 1 directly.
Display a notification with the number of unread messages.
CustomTriggerButton
DefaultTriggerButton
Approach taken / Explain the design
Each time the action of webchatReducer addMessageComponent is called if the webchat is closed and the message ack is 0, I increment the state of unreadMessages by 1. When I reset unreadMessages
The div displaying unread messages has className='trigger-notifications' to be able to adjust the css
To document / Usage example
Testing
The pull request...