Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botonic-react: upgrade react-textarea-autosize #2882

Merged
merged 11 commits into from
Aug 27, 2024

Conversation

Iru89
Copy link
Contributor

@Iru89 Iru89 commented Aug 2, 2024

Description

Upgrade version of react-textarea-autosize. This version is compatible with react 16, 17 or 18
Create a component Textarea to extract logic in a new file
Create a component WebchatInputPanel that group all inputs: text input, add emoji, add file, send button

Context

More PRs merged in this PR:

Approach taken / Explain the design

To document / Usage example

Testing

The pull request...

  • has unit tests
  • has integration tests
  • doesn't need tests because... [provide a description]

@Iru89 Iru89 force-pushed the webchat-user-input-textarea branch from c4fa3ee to ec09254 Compare August 2, 2024 12:09
@Iru89 Iru89 marked this pull request as ready for review August 19, 2024 10:58
packages/botonic-react/src/webchat/textarea/index.tsx Outdated Show resolved Hide resolved
Comment on lines 27 to 28
let isTyping = false
let typingTimeout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know this was probably done like this. not for this PR, but I think we should use refs instead of direct variables

packages/botonic-react/src/webchat/textarea/index.tsx Outdated Show resolved Hide resolved
autoFocus={false}
onKeyDown={e => onKeyDown(e)}
onKeyUp={onKeyUp}
style={{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this be passed through a styled component? have you tried it?

Copy link

github-actions bot commented Aug 22, 2024

Test Results

1 tests  ±0   1 ✅ ±0   3s ⏱️ -1s
1 suites ±0   0 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 3a9b16b. ± Comparison against base commit 586553c.

♻️ This comment has been updated with latest results.

@Iru89 Iru89 force-pushed the webchat-user-input-textarea branch from a5f4436 to 3a9b16b Compare August 27, 2024 13:07
@Iru89 Iru89 merged commit ab0da2e into master-lts Aug 27, 2024
2 checks passed
@Iru89 Iru89 deleted the webchat-user-input-textarea branch August 27, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants