-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Botonic cli: use endpoints /v2/bots/ for deploy #2892
Merged
Iru89
merged 6 commits into
botonic-cli/refactor-to-use-async-await-in-deploy
from
botonic-cli/endpoints-v2-bots
Aug 27, 2024
Merged
Botonic cli: use endpoints /v2/bots/ for deploy #2892
Iru89
merged 6 commits into
botonic-cli/refactor-to-use-async-await-in-deploy
from
botonic-cli/endpoints-v2-bots
Aug 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
force-pushed
the
botonic-cli/endpoints-v2-bots
branch
from
August 22, 2024 10:51
f918d29
to
cba6d26
Compare
MarcosCA
requested changes
Aug 26, 2024
vanbasten17
approved these changes
Aug 27, 2024
MarcosCA
approved these changes
Aug 27, 2024
## Description Use axios interceptors to update token using refreshToken when response status is 401 Refactor: - rename function saveBot to createBot - make private all functions that are only used inside BotonicAPIService class - getBots functions use getMoreBots internally to avoid repeat code ## Context Review commit by commit to follow the refactor
Iru89
merged commit Aug 27, 2024
f5ff39f
into
botonic-cli/refactor-to-use-async-await-in-deploy
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use new endpoints /v2/bots/ to deploy.
Send the bot_config as parameters in the POST call /v2/bots/ instead of adding the json in the separate folder next to the bot zip of the bot to be deployed.
Context
Approach taken / Explain the design
To document / Usage example
Testing
The pull request...