Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Botonic cli: use endpoints /v2/bots/ for deploy #2892

Conversation

Iru89
Copy link
Contributor

@Iru89 Iru89 commented Aug 22, 2024

Description

Use new endpoints /v2/bots/ to deploy.
Send the bot_config as parameters in the POST call /v2/bots/ instead of adding the json in the separate folder next to the bot zip of the bot to be deployed.

Context

Approach taken / Explain the design

To document / Usage example

Testing

The pull request...

  • has unit tests
  • has integration tests
  • doesn't need tests because... [provide a description]

Copy link

github-actions bot commented Aug 22, 2024

Test Results

30 tests  ±0   30 ✅ ±0   4m 17s ⏱️ -41s
 6 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit cba6d26. ± Comparison against base commit 9a234c5.

♻️ This comment has been updated with latest results.

@Iru89 Iru89 force-pushed the botonic-cli/endpoints-v2-bots branch from f918d29 to cba6d26 Compare August 22, 2024 10:51
packages/botonic-cli/src/botonic-api-service.ts Outdated Show resolved Hide resolved
packages/botonic-cli/src/botonic-api-service.ts Outdated Show resolved Hide resolved
packages/botonic-cli/src/botonic-api-service.ts Outdated Show resolved Hide resolved
@Iru89 Iru89 requested a review from MarcosCA August 27, 2024 10:49
packages/botonic-cli/src/botonic-api-service.ts Outdated Show resolved Hide resolved
packages/botonic-cli/src/commands/deploy.ts Show resolved Hide resolved
packages/botonic-cli/tests/commands/deploy.test.ts Outdated Show resolved Hide resolved
## Description

Use axios interceptors to update token using refreshToken when response
status is 401
Refactor:
- rename function saveBot to createBot
- make private all functions that are only used inside BotonicAPIService
class
- getBots functions use getMoreBots internally to avoid repeat code 

## Context

Review commit by commit to follow the refactor
@Iru89 Iru89 merged commit f5ff39f into botonic-cli/refactor-to-use-async-await-in-deploy Aug 27, 2024
2 checks passed
@Iru89 Iru89 deleted the botonic-cli/endpoints-v2-bots branch August 27, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants