Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't use tokenizer on config error #22

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

McPatate
Copy link
Member

  • Errors on missing tokenizer file made the lsp unusable when it could just default to no tokenizer
  • do tokenizer download in tokio::spawn so that on request cancel it continues to download the file and not leave a broken file

@McPatate McPatate merged commit fbaf982 into main Sep 25, 2023
@McPatate McPatate deleted the fix/tokenizer_download_cancel branch September 25, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant