feat!: make API camelCase #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
McPatate
force-pushed
the
feat!/getComletions_camelCase
branch
from
9a120cf
to
d8e313d
Compare
|
Hi, I am currently looking into the codebase because I really like the idea of using local or open LLMs to get code completion. I noticed this change and don't know why this was done, in the VSCode extension, snake_case is used throughout (https://github.com/huggingface/llm-vscode/blob/master/src/extension.ts#L151-L155) and even in the nvim and IntelliJ implementations. Is there any documentation as to what is right? |
|
Hi @HennerM, I haven't released a new version yet, I'll do so when I update all the extensions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API had inconsistencies in case