-
Notifications
You must be signed in to change notification settings - Fork 26.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip tests properly #31308
Skip tests properly #31308
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
17b18bc
to
8b91ec8
Compare
5a3df67
to
051d815
Compare
fee629e
to
41976a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, big change! Thank you for taking care of the library!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for being thourough
What does this PR do?
Makes sure all tests which are skipped are done so with an explicit skip. This helps with test stats, and doesn't make us think some tests are passing when they're actually empty which can be confusing c.f. this comment