Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ESM config files #413

Closed
achingbrain opened this issue Apr 5, 2022 · 0 comments · Fixed by #414
Closed

Support ESM config files #413

achingbrain opened this issue Apr 5, 2022 · 0 comments · Fixed by #414

Comments

@achingbrain
Copy link
Collaborator

The code tries to use lilconfig to load config files, but it only works with CJS files.

lilconfig supports loading ESM but it has to be done async.
achingbrain added a commit to achingbrain/playwright-test that referenced this issue Apr 5, 2022
@achingbrain
feat: support ESM config files
a064f99 
Uses `import` for dynamic module imports allowing you to use ESM
as a config file.

Also lets you return a function that returns a promise to get the
config in case you need to do some async work to retrieve it from
somewhere.

Fixes hugomrdias#413
@achingbrain achingbrain mentioned this issue Apr 5, 2022
Merged
achingbrain added a commit that referenced this issue Apr 6, 2022
@achingbrain
feat: support ESM config files (#414)
3f731c8 
Uses `import` for dynamic module imports allowing you to use ESM as a config file.

Also lets you return a function that returns a promise to get the config in case you need to do some async work to retrieve it from somewhere.

Fixes #413
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support ESM config files achingbrain/playwright-test
1 participant
@achingbrain