forward specialized BytesMut methods on {Encode,Decode}Buf #1358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forwards more
Buf
/BufMut
methods onEncodeBuf
andDecodeBuf
to take advantage of specialized implementations onBytesMut
, where available.Motivation
BytesMut
has some optimized variants ofBuf
andBufMut
methods that users ofEncodeBuf
andDecodeBuf
currently miss out on. In particular, an O(1) zero-copy variant ofBuf::copy_to_bytes
and variants ofBufMut::put
andBufMut::put_slice
that elide checkingremaining_mut
/advance_mut
.Solution
Provide specialized implementations of
Buf::copy_to_bytes
onDecodeBuf
as well asButMut::put
andBufMut::put_slice
onEncodeBuf
which forward these calls onto the underlyingBytesMut
implementations.