Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transport: allow setting max_header_list_size #1835

Merged
merged 1 commit into from
Aug 3, 2024

Commits on Aug 2, 2024

  1. transport: allow setting max_header_list_size

    There is a bug such that if the client sends a response with a header
    value that exceeds the max_header_list_size, then RPCs just hang
    (hyperium#1834). When tonic upgraded to hyper 1, it picked up [hyper#3622] which
    changed the default from 16MiB to 16KiB for this configuration value.
    Error messages in gRPC use headers. That means that services which ever
    sent error messages in excess of 16KiB (including in their error
    details!) will just hang.
    
    This commit adds the ability for the client to configure this value to
    something larger (perhaps the old default of 16MiB) to mitigate the
    above-referenced bug.
    
    [hyper#3622]: hyperium/hyper#3622
    ajwerner committed Aug 2, 2024
    Configuration menu
    Copy the full SHA
    78dbc18 View commit details
    Browse the repository at this point in the history