fix: Depend on at least tower 0.4.4 #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In tower 0.4.0 we missed a couple of re-exports that tonic 0.4.0 depends on. So tonic really depends on tower at least version 0.4.1. Since specifying your tower depedency as 0.4 means you might get 0.4.0, you might get build errors when updating tonic. Such as [hyperium#553] and [hyperium#552]. This fixes that by bumping tonic's dependency on tower to 0.4.4. That means users will get at least tower version 0.4.4, but semver compatible updates are still allowed. Fixes hyperium#553 [hyperium#553]: hyperium#553 [hyperium#552]: hyperium#552
LucioFranco
approved these changes
Feb 12, 2021
LucioFranco
changed the title
This was referenced Mar 18, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tower 0.4.0 we missed a couple of re-exports that tonic 0.4.0 depends
on. So tonic really depends on tower at least version 0.4.1. Since
specifying your tower depedency as 0.4 means you might get 0.4.0, you
might get build errors when updating tonic. Such as #553 and #552.
This fixes that by bumping tonic's dependency on tower to 0.4.4. That
means users will get at least tower version 0.4.4, but semver compatible
updates are still allowed.
Fixes #553