Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(fabric): jestify test cases #3582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adrianbatuto
Copy link
Contributor

@adrianbatuto adrianbatuto commented Oct 10, 2024

Commit to be reviewed


test(fabric): jestify test cases

Primary Changes
----------------
1. Updated the identified fabric tap tests to use jest:
2. Removed the tests from taprc and jest.config.js

Fixes #3547

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@adrianbatuto adrianbatuto force-pushed the adrianbatuto/issue3547 branch 3 times, most recently from a7bd488 to 38fa38b Compare October 10, 2024 07:52
@adrianbatuto adrianbatuto marked this pull request as ready for review October 10, 2024 10:48
Primary Changes
----------------
1. Updated the identified fabric tap tests to use jest:
2. Removed the tests from taprc and jest.config.js

Fixes hyperledger-cacti#3547

Signed-off-by: adrianbatuto <adrian.batuto@accenture.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test(fabric): jestify test cases
1 participant