Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace ursa lib with anoncreds-clsignatures-rs #226

Merged
merged 13 commits into from
Aug 3, 2023

Conversation

amanji
Copy link
Contributor

@amanji amanji commented Jul 20, 2023

Replaces ursa library with anoncreds-clsignatures-rs.
Removes some external dependencies which are now packaged with the updated library.
Resolves: #221
Resolves: #224

Many thanks to @andrewwhitehead for help on this.

Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
src/services/issuer.rs Show resolved Hide resolved
src/services/issuer.rs Show resolved Hide resolved
src/services/issuer.rs Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
Signed-off-by: Akiff Manji <akiff.manji@quartech.com>
@amanji
Copy link
Contributor Author

amanji commented Jul 25, 2023

Tagging @berendsliedrecht and @TimoGlastra for a review request.

@amanji amanji marked this pull request as ready for review July 25, 2023 15:24
@swcurran
Copy link
Member

Note about this on the interface changes made to those using this library:

  • The call to issue a credential no longer requires the tails file as a parameter.
  • The call to revoke a credential no longer requires the tails file as a parameter, adds the CredDefinition and the revocation registry private key as parameters.

Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that the JS part is fine. It misses the updates for React Native wrapper though. Not a common use case of course (and not sure if current issuance/revocation methods are properly working as we didn't test them systematically), so won't consider it as a blocker if not added to this PR.

@amanji
Copy link
Contributor Author

amanji commented Aug 3, 2023

Yes I should have mentioned that the RN wrappers were not updated. I assume they could be updated in a follow up PR to this.

@andrewwhitehead
Copy link
Member

anoncreds-clsignatures 0.2 is out now with a few more updates, but I can add another PR for that. I think the revocation status list creation could be optimized so I'll look at that at the same time.

@swcurran
Copy link
Member

swcurran commented Aug 3, 2023

anoncreds-clsignatures 0.2 is out now with a few more updates, but I can add another PR for that. I think the revocation status list creation could be optimized so I'll look at that at the same time.

@andrewwhitehead — what is the action here? Can we merge this, do we need to update to 0.2? Your note implies that we can do the 0.2 update later, but then you didn’t approve this. Thanks!

@swcurran swcurran merged commit 0e130ef into hyperledger:main Aug 3, 2023
25 checks passed
@TimoGlastra TimoGlastra mentioned this pull request Aug 4, 2023
genaris added a commit to genaris/anoncreds-rs that referenced this pull request Aug 12, 2023
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
@genaris genaris mentioned this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants