Simplify create_credential parameters and remove RevocationRegistryId #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
changed the title
TimoGlastra
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
Changes to the wrapper seem minimal (besides formatting). @genaris do you have time to update this in the JS wrapper?
I always have time for my beloved anoncreds-rs JS wrapper 😄. |
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
|
@andrewwhitehead FYI I submitted a PR to this branch updating JS wrappers according to these new changes: andrewwhitehead#1 |
fix(js): update create credential parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I understand, there's no such thing as a RevocationRegistryId, since RevocationRegistryDefinitionId covers that usage (for example, see within the Credential structure). Looking at the unit tests they seem to have been used interchangeably. If anything, I think there would need to be a RevocationStatusListId instead. So this PR removes RevocationRegistryId and just uses RevocationRegistryDefinitionId in its place.
When issuing via
create_credential, the revocation registry definition ID can be taken from the status list object.The Python wrapper is updated, but I haven't looked at updating the JS wrappers yet.