fix(rn): update libanoncreds headers #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ariel Gentile <gentilester@gmail.com>
berendsliedrecht
approved these changes
Feb 15, 2024
andrewwhitehead
approved these changes
Feb 15, 2024
|
Ouch that's my bad. We can probably release a js wrapper only 0.2.1 release. Can you make a version update PR @genaris? |
This was referenced Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was updating my react-native app to last credo alpha (which uses anoncreds-rs 0.2.0) and wasn't able to build in any OS due to a type error. It seems that the libanoncreds.h header wasn't updated after the changes in #320.
I've regenerated the file using
cbindgenand noticed several changes (like comments and some methods that were missing), so I guess it has been modified manually lately.