removed required prover_did #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: blu3beri <blu3beri@proton.me>
TimoGlastra
reviewed
Jan 11, 2023
anoncreds/src/data_types/mod.rs
Outdated
| @@ -3,7 +3,7 @@ mod utils { | |||
| pub use indy_utils::{qualifiable, Qualifiable}; | |||
| } | |||
|
|
|||
| pub use indy_utils::did; | |||
| //pub use indy_utils::did; | |||
anoncreds/src/services/prover.rs
Outdated
| @@ -46,6 +48,10 @@ pub fn create_credential_request( | |||
| credential_offer | |||
| ); | |||
|
|
|||
| let rand_str = String::from_utf8(thread_rng().sample_iter(&Alphanumeric).take(22).collect()) | |||
There was a problem hiding this comment.
The value prover_did should become optional in the whole credential request. If not present in the request, the issuer will generate it.
So if no prover_did is present we don't include it in the request
Signed-off-by: blu3beri <blu3beri@proton.me>
|
@TimoGlastra I think I fixed the issue, it was a bit unclear to me but this should hopefully be it. |
Signed-off-by: blu3beri <blu3beri@proton.me>
berendsliedrecht
force-pushed
the
ignore-prover-did
branch
from
9b77cd3
to
108a800
Compare
TimoGlastra
approved these changes
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #52
Implemented according to: hyperledger/anoncreds-spec#107 (comment)
Also removed the dependency on
indy_utils::DidValuewhich makes #40 a whole lot easier.Signed-off-by: blu3beri blu3beri@proton.me