Allow Configuration Settings on a per-tenant basis

[shaangill025]

• resolve Multitenancy: expose agent configuration settings on a per-tenant basis #2209
• Some changes related to getting BaseLedger instance from ledger_id won't be used right now but will be used soon with some proposed Traction features.

[swcurran]

Thanks, @shaangill025 — let us know about the test failures and we’ll look at moving this forward.

[shaangill025]

@swcurran I have added the documentation, this PR is ready for review.

[swcurran]

The goal was to get this into 0.8.2, but since the developer has not been available to work on this, it may not make it.

[usingtechnology]

I did not test the multiledger portion of this, just the tenant extra settings.

This is probably up for discussion. Should this (tenant extra settings) be a plugin?

In any case, what is missing is the tenant managing their settings. Currently, the base wallet/admin is the one creating the settings and updating them. A tenant/sub-wallet cannot access the /multitenancy APIs. I think the current changes can stay, but we should have another API /settings (?) that requires a tenant/sub-wallet token and they can manage those settings.

Tagging @loneil so the Traction team can review and chime in.

[shaangill025]

@usingtechnology The requested changes have been added.

[usingtechnology]

@shaangill025 - I would expect the tenant /settings API to update/return the small set of values not ALL of the settings. I realize your logic will only update the given set, but the API itself should NOT return all the settings. There are definitely things in there a tenant should not know. Can we limit to the set you provided? Also, I don't think those changes are persistent over server restarts. It doesn't appear that we are reading or writing from the wallet record (where the extra settings are initially stored).

Also, sorry if I wasn't really clear. The config/arg_parse is pretty confusing. That secondary mapping I was thinking about would match what someone puts into config.yml, so it's generally the dash separated key. Like log-level, auto-ping-connection, auto-accept-invites.

[usingtechnology]

Again, I haven't tested the ledger/indy_vdr changes, but the per tenant settings is almost ready to go. One simple change for the update API response.

[usingtechnology]

great work @shaangill025

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information