Added GraphQL service information to the response results of NetServices.

[ITStarMan100]

PR description

Added GraphQL service information to the response results of NetServices.

Fixed Issue(s)

fixes #7513

This PR is in response to this #7513

@non-fungible-nelson please review when you have some time.

[macfarla]

@jflo seems like another candidate for daggerization

[ITStarMan100]

I can update my code to use Dagger for dependency injection of the GraphQLConfiguration class.

I would like to ask @jflo if I can proceed by creating a GraphQLConfigurationModule.

[jflo]

I can update my code to use Dagger for dependency injection of the GraphQLConfiguration class.

I would like to ask @jflo if I can proceed by creating a GraphQLConfigurationModule.

Yes! the two most important questions to ask yourself when starting is 1) how is the thing created 2) what class ACTUALLY depends on it, directly. not transitively.

Once you know that, then you need to see if the other things it depends on during 1) can be provided via Dagger. This is often a stumbling block, but more things are added all the time. My current WIP is increasing what is available quite a bit.

[ITStarMan100]

If the work is still in progress, I can start working on Dagger once it's finished.
If there are no additional reviews needed for the current code, it might be better to proceed with integration.

[jflo]

yes, it's totally appropriate to refactor toward dagger in a future pr.

[ITStarMan100]

Will my PR be rejected?

[jflo]

Will my PR be rejected?

No it will not, just waiting on feedback/approval for this and we will merge it.

[ITStarMan100]

When I first submitted the PR, the check for testing on my local PC passed.

However, after 5 days and merging with the latest changes from besu main branch, it seems that there is an error in TxPoolOptionsTest.
(txpoolForcePriceBumpToZeroWhenZeroBaseFeeMarket() FAILED
org.mockito.exceptions.verification.WantedButNotInvoked at TxPoolOptionsTest.java:104)

Should I resubmit the PR with the latest changes from besu main branch?
Or is there a way to fix the issue in TxPoolOptionsTest since @jflo reviewed and approved my PR?

Can @jflo help me to fix this issue?

[ITStarMan100]

I'm getting the same check pass error as my PR (#7580) in "Moved maintainers to emeritus #7611".

What could be the reason?

[macfarla]

When I first submitted the PR, the check for testing on my local PC passed.

However, after 5 days and merging with the latest changes from besu main branch, it seems that there is an error in TxPoolOptionsTest. (txpoolForcePriceBumpToZeroWhenZeroBaseFeeMarket() FAILED org.mockito.exceptions.verification.WantedButNotInvoked at TxPoolOptionsTest.java:104)

Should I resubmit the PR with the latest changes from besu main branch? Or is there a way to fix the issue in TxPoolOptionsTest since @jflo reviewed and approved my PR?

Can @jflo help me to fix this issue?

think that is a flaky test that has been disabled in the meantime. checks now running on your updated PR 🤞