-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include consolidationRequestContract in jsonGenesisConfigOptions #7647
base: main
Are you sure you want to change the base?
Include consolidationRequestContract in jsonGenesisConfigOptions #7647
Conversation
Signed-off-by: gconnect <agatevureglory@gmail.com>
Signed-off-by: gconnect <agatevureglory@gmail.com>
…ntractAddress Signed-off-by: gconnect <agatevureglory@gmail.com>
@macfarla please review when you have the time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. If possible, wrap the addresses in a new class instead of passing the three addresses as parameters
...e/src/main/java/org/hyperledger/besu/ethereum/mainnet/requests/MainnetRequestsValidator.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
Signed-off-by: gconnect <agatevureglory@gmail.com>
I am thinking whether I should add this or leave it as it is. Because I noticed it wasn't added
|
Signed-off-by: gconnect <agatevureglory@gmail.com>
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
ethereum/core/src/main/java/org/hyperledger/besu/ethereum/mainnet/MainnetProtocolSpecs.java
Outdated
Show resolved
Hide resolved
Signed-off-by: gconnect <agatevureglory@gmail.com>
@Gabriel-Trintinalia I have made the requested changes. |
PR description
Fixed Issue(s)
fixes #7381
Thanks for sending a pull request! Have you done the following?
doc-change-required
label to this PR if updates are required.Locally, you can run these tests to catch failures early:
./gradlew build
./gradlew acceptanceTest
./gradlew integrationTest
./gradlew ethereum:referenceTests:referenceTests