Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[quorum] implement istanbul_propose method to add or remove a node #2516

Merged

Conversation

saurabhkumarkardam
Copy link
Contributor

Commit to be reviewed


feat(quorum): implement istanbul_propose method to add or remove a node

Changes:

  • Introduced new helm chart named quorum-propose-validator at path platforms/quorum/charts/.
  • This chart utilizes the istanbul_propose method to facilitate the addition or removal of nodes from the validator set based on majority votes.

fixes #2508

Copy link
Contributor

@suvajit-sarkar suvajit-sarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the quorum/chart/readme and operations guide in doc. Rest LGTM

Changes:
- Introduced new helm chart named `quorum-propose-validator` at path `platforms/quorum/charts/`.
- This chart utilizes the `istanbul_propose` method to facilitate the addition or removal of nodes from the validator set based on majority votes.

fixes hyperledger#2508

Signed-off-by: saurabhkumarkardam <saurabh.kumar.kardam@accenture.com>
Copy link
Contributor

@suvajit-sarkar suvajit-sarkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suvajit-sarkar suvajit-sarkar merged commit 2e96f93 into hyperledger:develop Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants