-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iroha-connector): add prometheus exporter to the plugin #3461
base: main
Are you sure you want to change the base?
feat(iroha-connector): add prometheus exporter to the plugin #3461
Conversation
8a9e656
to
901cab4
Compare
...tegration/plugin-ledger-connector-besu/deploy-contract/v21-deploy-contract-from-json.test.ts
Outdated
Show resolved
Hide resolved
...tegration/plugin-ledger-connector-besu/deploy-contract/v21-deploy-contract-from-json.test.ts
Outdated
Show resolved
Hide resolved
...cactus-plugin-ledger-connector-iroha2/src/main/typescript/cactus-iroha-sdk-wrapper/client.ts
Outdated
Show resolved
Hide resolved
.../cactus-plugin-ledger-connector-iroha2/src/main/typescript/plugin-ledger-connector-iroha2.ts
Outdated
Show resolved
Hide resolved
.../cactus-plugin-ledger-connector-iroha2/src/main/typescript/plugin-ledger-connector-iroha2.ts
Outdated
Show resolved
Hide resolved
...r-connector-iroha2/src/test/typescript/integration/iroha2-setup-and-basic-operations.test.ts
Outdated
Show resolved
Hide resolved
d12876e
to
44b7c44
Compare
@jagpreetsinghsasan Have addressed all requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashnashahgrover LGTM with comments (mostly just nit-picks)
...ector-iroha2/src/main/typescript/web-services/get-prometheus-exporter-metrics-endpoint-v1.ts
Outdated
Show resolved
Hide resolved
.../cactus-plugin-ledger-connector-iroha2/src/main/typescript/plugin-ledger-connector-iroha2.ts
Outdated
Show resolved
Hide resolved
44b7c44
to
ea7557d
Compare
Have addressed all the requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashnashahgrover Thank you for the updates, LGTM!
...r-iroha2/src/test/typescript/integration/iroha2-generate-and-send-signed-transaction.test.ts
Outdated
Show resolved
Hide resolved
...cactus-plugin-ledger-connector-iroha2/src/main/typescript/cactus-iroha-sdk-wrapper/client.ts
Outdated
Show resolved
Hide resolved
ea7557d
to
4740710
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, LGTM, please fix the CI so we can proceed with merging
4740710
to
c60fe15
Compare
fe6f61f
to
0aa2d50
Compare
Primary Changes ---------------- 1. Added Prometheus Exporter to Iroha ledger plugin 2. Added Prometheus Metrics tracker to relevant iroha tests. Fixes hyperledger#1260 Signed-off-by: ashnashahgrover <as19@williams.edu>
0aa2d50
to
d2b3c64
Compare
Commit to be reviewed
feat(iroha-connector): add prometheus exporter to the plugin
Fixes #1260
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.