-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: refactor jest test negative test cases - phase 1 #3488
base: main
Are you sure you want to change the base?
test: refactor jest test negative test cases - phase 1 #3488
Conversation
Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jagpreetsinghsasan
Should I make a issue to investigate the inconsistencies in deploy-contract-from-json-xdai.test.ts and make this issue dependent on that?
@ashnashahgrover Yes please! It's looking good in general but we need to make sure the test assertions are working as intended (and if we found an underlying bug then first we have to fix those in order to be able to prove that the asesrtions themselves work as intended)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I only found one small things to fix
packages/cactus-verifier-client/src/test/typescript/unit/verifier-factory.test.ts
Outdated
Show resolved
Hide resolved
947d28a
to
44ebecf
Compare
44ebecf
to
31c3426
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Primary Changes --------------- 1. Refactored all remaining negative test case exception assertions under cacti/packages Removed try-catch blocks, replaced with declarations through jest-extended's own API. Fixes hyperledger#3483 Signed-off-by: ashnashahgrover <ashnashahgrover777@gmail.com>
31c3426
to
69ce435
Compare
Commit to be reviewed
test: refactor jest test negative test cases - phase 1
Fixes #3483