test(test-tooling): add new besu AIO image builder utility #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Sep 8, 2024
Depends on hyperledger#3528 => test(test-tooling): add new besu AIO image builder utility Fixes hyperledger#3527 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
5 tasks
outSH
approved these changes
Sep 9, 2024
1. This will help author test cases for the Besu connector that are designed to be testing the latest version of the image instead of a pinned one that we pull from the registry as part of the test case. 2. We need tests for both latest and pinned image versions if we want to make sure that the connector is backward compatible with older ledger versions. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
force-pushed
the
test-tooling-besu-aio-image-builder
branch
from
1330b49
to
8c6b37c
Compare
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Sep 10, 2024
Depends on hyperledger#3528 => test(test-tooling): add new besu AIO image builder utility Fixes hyperledger#3527 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to be testing the latest version of the image instead of a pinned one that
we pull from the registry as part of the test case.
make sure that the connector is backward compatible with older ledger versions.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.