Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimum latency calculations could be scewed by failures #1065

Closed
davidkel opened this issue Oct 22, 2020 · 1 comment · Fixed by #1290
Closed

minimum latency calculations could be scewed by failures #1065

davidkel opened this issue Oct 22, 2020 · 1 comment · Fixed by #1290
Assignees
Labels
bug Something isn't working component/core Related to the core code-base
Milestone

Comments

@davidkel
Copy link
Contributor

An example of test output where init fails all of it's tries

+--------+------+------+-----------------+-----------------+------------------+-----------------+------------------+
| Name   | Succ | Fail | Send Rate (TPS) | Max Latency (s) | Min Latency (s)  | Avg Latency (s) | Throughput (TPS) |
|--------|------|------|-----------------|-----------------|------------------|-----------------|------------------|
| init1  | 0    | 24   | 5.4             | 0.00            | 9007199254740.99 | -               | 5.4              |
|--------|------|------|-----------------|-----------------|------------------|-----------------|------------------|
| query1 | 24   | 0    | 7.2             | 0.82            | 0.15             | 0.60            | 6.8              |
|--------|------|------|-----------------|-----------------|------------------|-----------------|------------------|
| init2  | 0    | 24   | 5.4             | 0.00            | 9007199254740.99 | -               | 5.4              |
|--------|------|------|-----------------|-----------------|------------------|-----------------|------------------|
| query2 | 24   | 0    | 7.2             | 0.68            | 0.17             | 0.56            | 6.9              |
+--------+------+------+-----------------+-----------------+------------------+-----------------+------------------+
@aklenik aklenik added the bug Something isn't working label Oct 27, 2020
@aklenik
Copy link
Contributor

aklenik commented Oct 27, 2020

I'm labeling this a bug. If we cannot calculate a metric, then it should be made explicit (both in code and in the report). The TransactionStatistics class current uses the Number.MAX_SAFE_INTEGER initial value for the min* attributes (for simpler implementation). Either that needs to be changed, or the reporting side has to check for that value (or if the corresponding counters are 0).

@davidkel davidkel added the component/core Related to the core code-base label Feb 3, 2022
@davidkel davidkel self-assigned this Mar 2, 2022
@davidkel davidkel added this to the v0.5.0 milestone Mar 2, 2022
@davidkel davidkel removed their assignment Mar 11, 2022
@davidkel davidkel self-assigned this Mar 24, 2022
davidkel pushed a commit to davidkel/caliper that referenced this issue Mar 29, 2022
davidkel added a commit that referenced this issue Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component/core Related to the core code-base
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants