Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't catch the error of commitTimeOut , because of the unit is not uniform #1141

Closed
workhard-12 opened this issue May 17, 2021 · 4 comments
Closed

can't catch the error of commitTimeOut , because of the unit is not uniform #1141

workhard-12 opened this issue May 17, 2021 · 4 comments
Assignees
@davidkel
Labels
bug Something isn't working component/fabric Related to the HL Fabric adapter documentation Related to the documentation
Milestone
v0.5.0

Comments

@workhard-12
Copy link

When we submit a tx , the unit of "commitTimeOut" should be seconds , but the caliper use milliseconds.
@aklenik
Copy link
Contributor

aklenik commented May 17, 2021

@workhard-12 Could you elaborate a bit, please? Which connector, which version/API?

@workhard-12
Copy link
Author

packages\caliper-fabric\lib\connector-versions\v2\FabricGateway.js

  • async _createGatewayWithIdentity(mspId, aliasName, wallet)
  • constructor(connectorConfiguration, workerIndex, bcType)

@davidkel davidkel added component/fabric Related to the HL Fabric adapter question Further information is requested bug Something isn't working documentation Related to the documentation and removed question Further information is requested labels Jan 17, 2022
@davidkel
Copy link
Contributor

davidkel commented Jan 17, 2022 •
edited
Loading

This is mainly a documentation issue as internally the code actually considers this to be seconds not milliseconds, however the default value of 60000 is assuming to be 60 seconds so the default value should change
see config.yaml + all the fabric implementations to change the defaults

@davidkel davidkel mentioned this issue Feb 4, 2022
Closed
3 tasks
davidkel pushed a commit to davidkel/caliper that referenced this issue Feb 21, 2022
update incorrect doc about timeout
d94813e 
documentation part to hyperledger#1141

Signed-off-by: D <d_kelsey@uk.ibm.com>
@davidkel davidkel mentioned this issue Feb 21, 2022
Merged
davidkel pushed a commit to davidkel/caliper that referenced this issue Feb 21, 2022
Correct timeout defaults
9f35590 
This is the apparent cause of a caliper run hang where it continues to
run with unfinished txns. It's actually waiting 60,000 seconds for txns
to finish which won't finish as it looks like the node sdk misses the
events.

code part of hyperledger#1141 also addresses in part

Signed-off-by: D <d_kelsey@uk.ibm.com>
@davidkel davidkel mentioned this issue Feb 21, 2022
Merged
davidkel added a commit that referenced this issue Feb 21, 2022
@davidkel
update incorrect doc about timeout (#1229)
657cc44 
documentation part to #1141

Signed-off-by: D <d_kelsey@uk.ibm.com>

Co-authored-by: D <d_kelsey@uk.ibm.com>
@davidkel davidkel self-assigned this Feb 21, 2022
davidkel added a commit that referenced this issue Feb 22, 2022
@davidkel
Correct timeout defaults (#1230)
cbacc35 
This is the apparent cause of a caliper run hang where it continues to
run with unfinished txns. It's actually waiting 60,000 seconds for txns
to finish which won't finish as it looks like the node sdk misses the
events.

code part of #1141 also addresses in part

Signed-off-by: D <d_kelsey@uk.ibm.com>

Co-authored-by: D <d_kelsey@uk.ibm.com>
@davidkel
Copy link
Contributor

Docs have been updated and code base has changed the default from 60,000 to 60. In the mean time you can override the default with

--caliper-fabric-timeout-invokeorquery 60

when you launch caliper

@davidkel davidkel added this to the v0.5.0 milestone Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidkel davidkel

Labels
bug Something isn't working component/fabric Related to the HL Fabric adapter documentation Related to the documentation
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
3 participants
@aklenik @davidkel @workhard-12