Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Caliper to NodeJS v14 (LTS) #965

Closed
nklincoln opened this issue Aug 27, 2020 · 9 comments
Closed

Upgrade Caliper to NodeJS v14 (LTS) #965

nklincoln opened this issue Aug 27, 2020 · 9 comments
Assignees
Labels
component/core Related to the core code-base
Milestone

Comments

@nklincoln
Copy link
Contributor

nklincoln commented Aug 27, 2020

engines.node is currently set at 10 ... we should bump this to the LTS version of node, which in now v14

Consequences:

This impacts on Fabric SDK binding (only able to bind to latest), consequently we would have to:

  • only bind to 1.4 and 2.2 latest (that uses grpc-js)
  • provide guidance (or an alternative image?) for those wishing/restricted to lower versions of the SDKs

Alterations:

  • All packages
  • Travis build
  • Caliper image
  • Documentation for building own image and/or specifying custom bindings (enhanced binding stage/page)
  • Breaking change, version bump required
@nklincoln nklincoln added this to the v0.4.0 milestone Aug 27, 2020
@nklincoln nklincoln mentioned this issue Sep 1, 2020
6 tasks
@nklincoln nklincoln self-assigned this Sep 2, 2020
@nklincoln nklincoln modified the milestones: v0.4.0, Future release Sep 16, 2020
@nklincoln nklincoln modified the milestones: Future release, v0.5.0 Sep 24, 2020
@nklincoln nklincoln added the component/core Related to the core code-base label Oct 2, 2020
@nklincoln nklincoln changed the title bump node version through all packages Upgrade Caliper to NodeJS v14 (LTS) Oct 28, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 25, 2020
@nklincoln nklincoln removed the wontfix This will not be worked on label Jan 19, 2021
@stale
Copy link

stale bot commented Apr 13, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Apr 13, 2021
@davidkel davidkel removed the wontfix This will not be worked on label Apr 14, 2021
@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jun 11, 2021
@davidkel davidkel removed the wontfix This will not be worked on label Jan 17, 2022
@naonishijima
Copy link

Would it be possible to give me an update on this issue? Is there something I can help with?

@aklenik
Copy link
Contributor

aklenik commented Jan 26, 2022

@naonishijima Feel free to join the caliper-contributors Rocket.Chat channel, where we can discuss the details and steps of the version bump: https://chat.hyperledger.org/channel/caliper-contributors

@fraVlaca
Copy link
Contributor

fraVlaca commented Feb 3, 2022

picking up this issue and updating dependencies to run caliper on node 14 LTS (v14.19.0 (npm v6.14.16))

@davidkel davidkel assigned fraVlaca and unassigned nklincoln Feb 3, 2022
@fraVlaca
Copy link
Contributor

fraVlaca commented Feb 8, 2022

  • move as many npm dependencies to the latest versions available(Fabric dependencies need to stick to 1.4 rather than 2.2)
  • remove the "^" symbols (because of the colors npm module being sabotaged) and using explicit versions
  • ship package-lock.json files

@davidkel
Copy link
Contributor

@naonishijima @aklenik
Current status

  • caliper 0.4.2 can be used with node 14, the only issue is that the fabric 1.4 SUT can't be used
  • The caliper repo itself now works with node 14 (although it's not optimised as yet) with a couple more updates to come to complete (ie 2 integration test builds to move to node 14, creation of the docker image to use node14)

@davidkel
Copy link
Contributor

I think this issue is now done, there are some follow-ons as described in these issues
#1222
#1217
#1125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core Related to the core code-base
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants