Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node engines to v10, matching travis and caliper image build #1053

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

nklincoln
Copy link
Contributor

Contributes to #965

Bump node engines to v10.22, which matches:

  • travis build engine
  • caliper image published to docker hub

bump in npm to that matching the v10.22 build (6.14.0)

This PR has no impact on ability to bootstrap, or subsequent binding ... jumping above v10 will

Signed-off-by: nkl199@yahoo.co.uk nkl199@yahoo.co.uk

Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk>
Copy link
Contributor

@davidkel davidkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nklincoln nklincoln merged commit ec42990 into hyperledger:master Oct 19, 2020
@nklincoln nklincoln deleted the align-node-versions branch October 19, 2020 09:01
danielporto pushed a commit to danielporto/caliper that referenced this pull request Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants