Make options robust and add unit tests to prom monitors #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklincoln
force-pushed
the
prom-monitor-options
branch
from
b37c77c
to
58d95ab
Compare
davidkel
reviewed
Sep 30, 2020
davidkel
reviewed
Sep 30, 2020
aklenik
reviewed
Sep 30, 2020
packages/caliper-core/test/worker/tx-observers/prometheus-push-tx-observer.js
Outdated
Show resolved
Hide resolved
nklincoln
force-pushed
the
prom-monitor-options
branch
from
58d95ab
to
96a2fc9
Compare
Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk>
nklincoln
force-pushed
the
prom-monitor-options
branch
from
96a2fc9
to
99217a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When experimenting, I found that the current option settings for the prom monitors is not particularly robust.
I have modified the constructors to pull from sensible defaults if not present, and added unit tests to support the prometheus monitors
Signed-off-by: nkl199@yahoo.co.uk nkl199@yahoo.co.uk