Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update txCollector and add unit tests #1045

Merged
merged 1 commit into from
Oct 16, 2020

Conversation

nklincoln
Copy link
Contributor

Signed-off-by: nkl199@yahoo.co.uk nkl199@yahoo.co.uk

closes #1044

Fixes bug and add unit tests

Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor clarity-aiding refactoring for the tests, otherwise nice fix 👍

@nklincoln nklincoln force-pushed the txCollector branch 2 times, most recently from bc63b11 to ad523eb Compare October 14, 2020 15:01
Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk>
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@aklenik aklenik merged commit ce7516c into hyperledger:master Oct 16, 2020
@nklincoln nklincoln deleted the txCollector branch October 19, 2020 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative send rate can be observed in reports
2 participants