-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure pipelines build #1105
Azure pipelines build #1105
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two non-blocking comments only
.travis.yml
Outdated
@@ -10,7 +10,7 @@ dist: xenial | |||
before_install: | | |||
set -ev | |||
set -o pipefail | |||
npm install -g @alrra/travis-scripts | |||
npm install -g @alrra/build-scripts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this rename intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 don't actually remember changing this on, i will revert the change
azure-pipelines.yml
Outdated
# Node.js | ||
# Build a general Node.js project with npm. | ||
# Add steps that analyze code, save build artifacts, deploy, and more: | ||
# https://docs.microsoft.com/azure/devops/pipelines/languages/javascript |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need license in yaml files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks to be a bit of self publication from microsoft - it was an autogenerated document
Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk>
542aba3
to
72f67f7
Compare
Contributes to #1102
Introduces Azure pipeline build
Signed-off-by: nkl199@yahoo.co.uk nkl199@yahoo.co.uk