Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caliper terminates if prometheus is not available #1288

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

davidkel
Copy link
Contributor

This is due to the error event not being correctly captured when a
request is made to prometheus

Also added some extra code to output a warning and stop trying to do any
more queries for the round.

It won't stop it for all rounds but checks on every round.

closes #1267

Signed-off-by: D d_kelsey@uk.ibm.com

This is due to the error event not being correctly captured when a
request is made to prometheus

Also added some extra code to output a warning and stop trying to do any
more queries for the round.

It won't stop it for all rounds but checks on every round.

closes hyperledger#1267

Signed-off-by: D <d_kelsey@uk.ibm.com>
@davidkel davidkel requested a review from aklenik March 24, 2022 14:30
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkel davidkel merged commit ada19c3 into hyperledger:main Mar 24, 2022
@davidkel davidkel deleted the fixprom branch March 24, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test runs should not fail if it's not possible to extract prometheus data
2 participants