Change monitor intervals from milliseconds to seconds #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the fabric tests the monitor intervals were set to single millisecond values such as 3, 4, 5. This adds a massive overhead to the running of the integration tests and isn't needed, so changing them to be seconds instead. Signed-off-by: D <d_kelsey@uk.ibm.com>
aklenik
approved these changes
Apr 15, 2022
There was a problem hiding this comment.
This is probably a leftover bug from when interval was considered as seconds.
Maybe we should look at unifying the duration specifications across Caliper with something like this: https://www.npmjs.com/package/parse-duration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the fabric tests the monitor intervals were set to single
millisecond values such as 3, 4, 5. This adds a massive overhead to the
running of the integration tests and isn't needed, so changing them to
be seconds instead.
Signed-off-by: D d_kelsey@uk.ibm.com