Ensure that connector errors finishes caliper transactions #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A Scenario was discovered where if you send a single txn and the
connector throws an error then that single txn never finishes and the
worker loops forever waiting for that transaction to finish.
eg in the workload
```
invokerIdentity: 'unknownuser'
```
example benchmark
```
test:
name: fixed-asset-test
description: >-
This is a test yaml for the existing fixed-asset benchmarks
workers:
type: local
number: 1
rounds:
- label: empty-contract-evaluate
chaincodeID: fixed-asset
txNumber: 1
rateControl:
type: fixed-rate
opts:
tps: 2
workload:
module: benchmarks/api/fabric/workloads/empty-contract.js
arguments:
chaincodeID: fixed-asset
consensus: false
```
In the wider support for connectors though the caliper framework should
ensure that connectors that either don't handle errors or throw errors
should make sure that the submission is registered as a failure (which
is what a connector would do if it did catch an error)
This fix ensures that any error received will mark a transaction as
finished
closes hyperledger#1068
Signed-off-by: D <d_kelsey@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A Scenario was discovered where if you send a single txn and the
connector throws an error then that single txn never finishes and the
worker loops forever waiting for that transaction to finish.
eg in the workload
example benchmark
In the wider support for connectors though the caliper framework should
ensure that connectors that either don't handle errors or throw errors
should make sure that the submission is registered as a failure (which
is what a connector would do if it did catch an error)
This fix ensures that any error received will mark a transaction as
finished
closes #1068
Signed-off-by: D d_kelsey@uk.ibm.com