Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes caliper hang of unfinished transactions #1342

Merged
merged 1 commit into from
May 17, 2022

Conversation

davidkel
Copy link
Contributor

This addresses a long standing issue in caliper where a round will hang
waiting for unfinished transactions that have actually finished but not
been recorded.

It also addresses an issue where the fabric connectors try to change the
time_create value of a TxStatus but in fact actually doesn't change the
creation time.

closes #1068
closes #1340

Signed-off-by: D d_kelsey@uk.ibm.com

This addresses a long standing issue in caliper where a round will hang
waiting for unfinished transactions that have actually finished but not
been recorded.

It also addresses an issue where the fabric connectors try to change the
time_create value of a TxStatus but in fact actually doesn't change the
creation time.

closes hyperledger#1068
closes hyperledger#1340

Signed-off-by: D <d_kelsey@uk.ibm.com>
@davidkel davidkel requested a review from aklenik May 17, 2022 07:43
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 🥇

@davidkel davidkel merged commit 2fd8925 into hyperledger:main May 17, 2022
@davidkel davidkel deleted the fixunfinished branch May 17, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants