Make report file path configurable #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklenik
requested review from
feihujiang,
jiangyaoguo,
liam-grace,
nklincoln and
panyu4
as code owners
|
This pull request introduces 1 alert when merging 431e499 into cdd1a0b - view on LGTM.com new alerts:
|
Signed-off-by: Attila Klenik <a.klenik@gmail.com>
nklincoln
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Klenik a.klenik@gmail.com
Resolves #597
The PR makes the reporting path configurable through the usual runtime config mechanism. Plus exposes the file access settings, which can come in handy when the container executes Caliper as root.