New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Dockerfile for global modules #795

Merged

aklenik merged 1 commit into hyperledger:master from aklenik:fix-dockerfile

Apr 9, 2020

Contributor

aklenik commented Apr 9, 2020

Signed-off-by: Attila Klenik a.klenik@gmail.com

The core module is installed explicitly, so it's placed at the root of the global node_modules folder. The other core deps are deduped to this.
NODE_PATH is set to the global node_modules folder, so external modules (like the workload module) can require it without explicitly installing it as its own dependency (and possibly breaking singleton patterns, since that'll be a different module).


          Improve Dockerfile for global modules

30fa628

Signed-off-by: Attila Klenik <a.klenik@gmail.com>

aklenik requested review from feihujiang, jiangyaoguo, liam-grace, nklincoln and panyu4 as code owners

April 9, 2020 13:38

nklincoln approved these changes

View reviewed changes

Contributor

nklincoln left a comment

lgtm 👍

aklenik merged commit 1d1e759 into hyperledger:master

aklenik deleted the fix-dockerfile branch

April 17, 2020 16:16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nklincoln nklincoln approved these changes

feihujiang Awaiting requested review from feihujiang

jiangyaoguo Awaiting requested review from jiangyaoguo

liam-grace Awaiting requested review from liam-grace

panyu4 Awaiting requested review from panyu4

Labels

None yet