Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global change of chaincode -> contract #891

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

nklincoln
Copy link
Contributor

Contributes to #871

Replaces all master branch occurrences of chaincode with contract to ensure that caliper only considers smart contracts.

ToDo requirement following this PR is updating of:

  • gh-pages (vNext)
  • caliper-benchmarks (Fabric network configuration files)

Signed-off-by: nkl199@yahoo.co.uk nkl199@yahoo.co.uk

@nklincoln nklincoln requested a review from aklenik June 29, 2020 19:23
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some renamings should be reverted, mostly concerning SDK objects, functions, chaincode sources, or Fabric-side metric labels.

@nklincoln nklincoln force-pushed the chaincode-to-contract branch 3 times, most recently from f0ff653 to b239e6e Compare June 30, 2020 08:22
Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk>
Copy link
Contributor

@aklenik aklenik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aklenik aklenik merged commit 46bbd0d into hyperledger:master Jun 30, 2020
@nklincoln nklincoln deleted the chaincode-to-contract branch July 9, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants