add prometheus scrape target tx observer #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 3db2036 into a561f64 - view on LGTM.com new alerts:
|
nklincoln
force-pushed
the
prometheus-scrape
branch
from
3db2036
to
a6a4f1d
Compare
davidkel
reviewed
Aug 27, 2020
| */ | ||
| txFinished(results) { | ||
| if (Array.isArray(results)) { | ||
| for (let result of results) { |
nklincoln
force-pushed
the
prometheus-scrape
branch
from
a6a4f1d
to
f5c9fff
Compare
Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk>
nklincoln
force-pushed
the
prometheus-scrape
branch
from
f5c9fff
to
80a778c
Compare
davidkel
approved these changes
Aug 27, 2020
danielporto
pushed a commit
to danielporto/caliper
that referenced
this pull request
Nov 3, 2020
Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #637
Provides a prometheus-tx-observer that enables each worker to act as a scrape target with the following metrics exposed:
User may provide options for:
Follow up PR should modify they PushGateway to use the same metrics
Signed-off-by: nkl199@yahoo.co.uk nkl199@yahoo.co.uk