Modify prometheus monitor #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 1, 2020
davidkel
reviewed
Sep 8, 2020
| const response = await this.prometheusQueryClient.getByEncodedUrl(queryString); | ||
|
|
||
| // Retrieve base mapped statistics and coerce into correct format | ||
| const resultMap = PrometheusQueryHelper.extractStatisticFromRange(response, params.statistic, params.label); | ||
| const resultMap = PrometheusQueryHelper.extractStatisticFromRange(response, queryObject.statistic, queryObject.label); |
There was a problem hiding this comment.
would be good if this variable described what it actually contained
davidkel
reviewed
Sep 8, 2020
|
|
||
| const metricArray = []; | ||
| let newQuery = true; | ||
| for (const [key, value] of resultMap.entries()) { |
There was a problem hiding this comment.
can be be a bit more descriptive on what a key really is and what the value might be ?
davidkel
reviewed
Sep 8, 2020
| * @param {string} key the key to test fro inclusion | ||
| * @returns {boolean} boolean flag for inclusion | ||
| */ | ||
| includeStatistic(key) { |
There was a problem hiding this comment.
can we be more specific then just key ?
davidkel
reviewed
Sep 8, 2020
|
|
||
| /** | ||
| * Check if the passed key should be included | ||
| * @param {string} key the key to test fro inclusion |
nklincoln
force-pushed
the
prometheus-monitor
branch
from
2b45c1d
to
3db3ce2
Compare
davidkel
reviewed
Sep 15, 2020
| const resourceStats = []; | ||
| const chartArray = []; | ||
| for (const metricKey of Object.keys(this.include)) { | ||
| let newKey = true; | ||
| for (const queryObject of this.queries) { | ||
| // Each metric is of the form |
There was a problem hiding this comment.
Comment say's metric, but all I see is queryObject so not sure how they relate.
Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk>
nklincoln
force-pushed
the
prometheus-monitor
branch
from
3db3ce2
to
02be251
Compare
davidkel
approved these changes
Sep 15, 2020
danielporto
pushed a commit
to danielporto/caliper
that referenced
this pull request
Nov 3, 2020
Signed-off-by: nkl199@yahoo.co.uk <nkl199@yahoo.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #964
Requires companion docs for breaking change
Signed-off-by: nkl199@yahoo.co.uk nkl199@yahoo.co.uk