adding an option for outbound concurrency control #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Chengxuan
requested review from
peterbroadhurst,
nguyer and
awrichar
as code owners
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Codecov Report
@@ Coverage Diff @@
## main #36 +/- ##
==========================================
- Coverage 98.80% 98.39% -0.41%
==========================================
Files 34 34
Lines 2674 2685 +11
==========================================
Hits 2642 2642
- Misses 25 35 +10
- Partials 7 8 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peterbroadhurst
requested changes
Mar 14, 2023
There was a problem hiding this comment.
Think this is a great addition @Chengxuan
One request to avoid blocking infinitely, rather than up to a context timeout
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
Signed-off-by: Chengxuan Xing <chengxuan.xing@kaleido.io>
peterbroadhurst
approved these changes
May 15, 2023
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
|
This will drop coverage I think, so I'll submit a follow-on PR to address that @Chengxuan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some blockchain endpoint has a concurrent limit, add an option here to control the number of concurrent requests.