test: initial subxt test #990

extraymond · 2022-08-28T05:49:37Z

alternative tests using subxt, currently using raw selector until the ABI are compatible where we can just use contract-transcode.
test cases are semantically derived from the original substrate integration tests using polkadot.js.

extraymond · 2022-08-30T18:35:37Z

Started to use contract-transcode for encoding message selector, which works with the two exception:

when using constructor overloading, due to all constructors have the same name, which contract-transcode will only match the first one, currently it'll never reach the second constructor.
transcoding U256/I256 won't work. U256 is configured with sp_core::U256 as it's custom transcoder but it won't actually use it since it's using the TypeInfo::type_info() to get the Path, which is all empty for solang runtime types. I256 is unprocessed at all.

xermicus · 2022-08-31T10:59:06Z

I think this is a great effort overall!

when using constructor overloading, due to all constructors have the same name, which contract-transcode will only match the first one, currently it'll never reach the second constructor.

Options I see so far:

Introduce a custom attribute to set a name for the constructor (e.g. like the way it is done for selector), and default to new or something else when no overloading is happening and no name is given.
Mangle the name based by its arguments, would be less work to code up I guess, but ugly from a user perspective

transcoding U256/I256 won't work. U256 is configured with sp_core::U256 as it's custom transcoder but it won't actually use it since it's using the TypeInfo::type_info() to get the Path, which is all empty for solang runtime types. I256 is unprocessed at all.

U256 is not (yet) supported in ink!. The easiest solution would be if we can get it to work by using the U256 path of ethereum-types lib somehow?

seanyoung

First review comments, looks good so far

.github/workflows/test.yml

.gitignore

integration/subxt-tests/Cargo.toml

integration/subxt-tests/src/cases/structs.rs

xermicus · 2022-11-21T11:10:14Z

@extraymond it makes me sad that we didn't go forward sooner with this PR, sorry! I really like what you implemented here. In the long run, it would make sense to integrate this with #1061. How-ever, this should not block your nice work here. May I ask you for the favor of merging current main with this again? Then I'd be very happy to give a usual round of review and LGTM!

extraymond · 2022-11-21T12:16:44Z

@extraymond it makes me sad that we didn't go forward sooner with this PR, sorry! I really like what you implemented here. In the long run, it would make sense to integrate this with #1061. How-ever, this should not block your nice work here. May I ask you for the favor of merging current main with this again? Then I'd be very happy to give a usual round of review and LGTM!

Sure! I'll be on it sometime this week.

xermicus · 2022-11-23T10:41:52Z

Sure! I'll be on it sometime this week.

Awesome, thanks! While you're on it, can you directly aim for compatibility with pallets contract v0.22.1 (it uses WeightV2)? Not all contracts will work ATM though, as I have to fix some imports first (gonna make a PR for this).

EDIT: #1080

Signed-off-by: Raymond Yeh <extraymond@gmail.com>

extraymond · 2023-06-18T11:40:10Z

@xermicus @seanyoung
Rebased to current master. Some failed tests are ignored as suggested. Looking forward for your review.

Signed-off-by: Raymond Yeh <extraymond@gmail.com>

xermicus · 2023-06-19T07:50:16Z

@extraymond FYI the rust source files need a SPDX header, this is why the Lints job failed (unfortunately it'll just time out if there are some headers missing)

extraymond · 2023-06-19T07:51:21Z

Ah! Got it.

@extraymond FYI the rust source files need a SPDX header, this is why the Lints job failed (unfortunately it'll just time out if there are some headers missing)

Ah got it, I'll fix it later.

xermicus

Gave it a first round of review; looks great overall, I hope to merge this soon. Thank you so much for keeping this going! ❤️

.github/workflows/test.yml

integration/subxt-tests/src/lib.rs

.github/workflows/test.yml

integration/subxt-tests/src/cases/arrays.rs

integration/subxt-tests/src/cases/events.rs

integration/subxt-tests/src/cases/external_call.rs

Signed-off-by: Raymond Yeh <extraymond@gmail.com>

extraymond · 2023-06-19T11:30:01Z

@xermicus I think it would be nice to tap into debug buffer when contract trapped. It's very hard to debug why it's trapped within the test.

xermicus · 2023-06-19T11:44:35Z

@xermicus I think it would be nice to tap into debug buffer when contract trapped. It's very hard to debug why it's trapped within the test.

I see what you mean; however I think this should ideally be done by contracts pallet (so the runtime executing the contract). In the contract code itself, we have limited control about trapping. We might write into the debug buffer if we know for sure we are going to trap (for example because the compiler inserts a trap manually). However, there are many other cases (OOM, invalid instructions etc) only the runtime knows or has control about.

For this to work we would need to provide the runtime debug info, but for now IIRC the contracts pallet doesn't support this.

extraymond · 2023-06-19T11:47:32Z

@xermicus I think it would be nice to tap into debug buffer when contract trapped. It's very hard to debug why it's trapped within the test.

I see what you mean; however I think this should ideally be done by contracts pallet (so the runtime executing the contract). In the contract code itself, we have limited control about trapping. We might write into the debug buffer if we know for sure we are going to trap (for example because the compiler inserts a trap manually). However, there are many other cases (OOM, invalid instructions etc) only the runtime knows or has control about.

For this to work we would need to provide the runtime debug info, but for now IIRC the contracts pallet doesn't support this.

Yeah, cargo-contract does it by doing a sequential read call if a first write call failed. Maybe we should revisit it later when we have some shared lib from cargo-contract that we can directly pulled.

LucasSte

LGTM

integration/subxt-tests/src/cases/primitives.rs

Signed-off-by: Raymond Yeh <extraymond@gmail.com>

extraymond · 2023-06-21T07:05:23Z

@seanyoung I think one of my forced push for rebase cleared your original change request. I believe I have implemented the suggestion back then.

xermicus

LGTM

seanyoung

Looks great. I only skimmed the new tests - a huge amount, great stuff!

.github/workflows/test.yml

BREAKING CHANGE: Signed-off-by: Raymond Yeh <extraymond@gmail.com>

xermicus · 2023-06-21T13:02:17Z

Amazing, thank you!

seanyoung · 2023-06-21T14:25:33Z

@extraymond good stuff, thanks!

extraymond force-pushed the subxt-tests branch from 65a4cc4 to a8d68ea Compare August 30, 2022 18:23

extraymond force-pushed the subxt-tests branch 2 times, most recently from 4c58a90 to 9e9a8d8 Compare September 5, 2022 10:21

seanyoung requested changes Sep 5, 2022

View reviewed changes

extraymond force-pushed the subxt-tests branch from 9e9a8d8 to ae22b0a Compare September 5, 2022 13:09

xermicus mentioned this pull request Sep 13, 2022

Milestone 1: Ensure Solang works with latest Substrate #969

Closed

26 tasks

extraymond force-pushed the subxt-tests branch from c993688 to 627ac9b Compare September 13, 2022 11:57

xermicus added this to the `ink! v4` compatibility milestone Oct 5, 2022

xermicus modified the milestones: ink! v4 compatibility, Substrate: Improve developer experience Nov 8, 2022

extraymond force-pushed the subxt-tests branch 3 times, most recently from ea9c7d4 to 2b6b2af Compare May 31, 2023 11:42

extraymond mentioned this pull request Jun 2, 2023

[client library] decouple extrinsics related ability as library use-ink/cargo-contract#1140

Closed

test(subxt-tests): integration test for substrate using subxt

e8109b6

Signed-off-by: Raymond Yeh <extraymond@gmail.com>

extraymond force-pushed the subxt-tests branch from fc3c704 to e8109b6 Compare June 18, 2023 11:39

extraymond changed the title ~~WIP: test: initial subxt test~~ test: initial subxt test Jun 18, 2023

extraymond added 2 commits June 18, 2023 12:37

test: use the same docker image for substrate-contracts-node

05ef0bf

Signed-off-by: Raymond Yeh <extraymond@gmail.com>

test: fix input encoding

fd741a0

Signed-off-by: Raymond Yeh <extraymond@gmail.com>

xermicus reviewed Jun 19, 2023

View reviewed changes

xermicus mentioned this pull request Jun 19, 2023

Substrate: Event decoding does not match ink! #1373

Open

test: add spdx-header, use runtime_metadata_url remove uneed env_var

fefbe78

Signed-off-by: Raymond Yeh <extraymond@gmail.com>

test: add test failed reason in ignore

1781cc0

Signed-off-by: Raymond Yeh <extraymond@gmail.com>

xermicus marked this pull request as ready for review June 19, 2023 12:42

xermicus requested a review from LucasSte as a code owner June 19, 2023 12:42

xermicus requested a review from seanyoung June 19, 2023 12:42

LucasSte approved these changes Jun 20, 2023

View reviewed changes

integration/subxt-tests/src/cases/primitives.rs Outdated Show resolved Hide resolved

style: typo

6f6caff

Signed-off-by: Raymond Yeh <extraymond@gmail.com>

xermicus approved these changes Jun 21, 2023

View reviewed changes

seanyoung approved these changes Jun 21, 2023

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

.github/workflows/test.yml Outdated Show resolved Hide resolved

ci: update CI to 22.04, reduce test step

0a9b68e

BREAKING CHANGE: Signed-off-by: Raymond Yeh <extraymond@gmail.com>

xermicus merged commit 0170778 into hyperledger:main Jun 21, 2023
16 of 17 checks passed

xermicus mentioned this pull request Jun 29, 2023

[test] use subxt as alternative integration test for substrate #965

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: initial subxt test #990

test: initial subxt test #990

extraymond commented Aug 28, 2022

extraymond commented Aug 30, 2022 •

edited

Loading

xermicus commented Aug 31, 2022

seanyoung left a comment

xermicus commented Nov 21, 2022 •

edited

Loading

extraymond commented Nov 21, 2022

xermicus commented Nov 23, 2022 •

edited

Loading

extraymond commented Jun 18, 2023

xermicus commented Jun 19, 2023

extraymond commented Jun 19, 2023

xermicus left a comment

extraymond commented Jun 19, 2023

xermicus commented Jun 19, 2023

extraymond commented Jun 19, 2023

LucasSte left a comment

extraymond commented Jun 21, 2023

xermicus left a comment

seanyoung left a comment

xermicus commented Jun 21, 2023

seanyoung commented Jun 21, 2023

test: initial subxt test #990

test: initial subxt test #990

Conversation

extraymond commented Aug 28, 2022

extraymond commented Aug 30, 2022 • edited Loading

xermicus commented Aug 31, 2022

seanyoung left a comment

Choose a reason for hiding this comment

xermicus commented Nov 21, 2022 • edited Loading

extraymond commented Nov 21, 2022

xermicus commented Nov 23, 2022 • edited Loading

extraymond commented Jun 18, 2023

xermicus commented Jun 19, 2023

extraymond commented Jun 19, 2023

xermicus left a comment

Choose a reason for hiding this comment

extraymond commented Jun 19, 2023

xermicus commented Jun 19, 2023

extraymond commented Jun 19, 2023

LucasSte left a comment

Choose a reason for hiding this comment

extraymond commented Jun 21, 2023

xermicus left a comment

Choose a reason for hiding this comment

seanyoung left a comment

Choose a reason for hiding this comment

xermicus commented Jun 21, 2023

seanyoung commented Jun 21, 2023

extraymond commented Aug 30, 2022 •

edited

Loading

xermicus commented Nov 21, 2022 •

edited

Loading

xermicus commented Nov 23, 2022 •

edited

Loading