Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/different origins #4

Merged
merged 6 commits into from
Oct 5, 2015
Merged

Feature/different origins #4

merged 6 commits into from
Oct 5, 2015

Conversation

RamonGilabert
Copy link
Contributor

app

The first screen won't contain the container screen, but right now it does. @zenangst, @vadymmarkov.

zenangst added a commit that referenced this pull request Oct 5, 2015
@zenangst zenangst merged commit 367f9e6 into master Oct 5, 2015
@zenangst zenangst deleted the feature/different-origins branch October 5, 2015 20:35
@zenangst
Copy link
Contributor

zenangst commented Oct 5, 2015

🍃

@@ -187,6 +216,20 @@ class WhisperFactory: NSObject {

extension WhisperFactory: UINavigationControllerDelegate {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zenangst @RamonGilabert With the name like WhisperFactory I'm expecting to see creation of objects, but it's not the purpose of this class. Might be only me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

factory |ˈfakt(ə)rē|
noun (pl. factories)
1 a building or group of buildings where goods are manufactured or assembled chiefly by machine.

We manufacture Whispers, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking about Factory pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants