Computes Murmur's height dynamically #53
Conversation
|
This looks neat! What do you guys think? @RamonGilabert @vadymmarkov |
|
This is super useful :) |
|
Thanks guys :) |
|
+1 |
|
Hey @acadet, sorry about the super long delay. Been some crazy days at the office. I see two problems in the PR, one is the indentation, easy fix, we are using a 2 indentation for the projects, the PR I see is 4, just a small thing! :) The other thing is that you "kill" the constant height, that means that, if the sizeToFit is smaller than the status bar, Whistle will be smaller, would it? You could put like a check if it's smaller to use the dimensions. What do you think? |
| let neededDimensions = | ||
| NSString(string: text).boundingRectWithSize( | ||
| CGSize(width: labelWidth, height: CGFloat.infinity), | ||
| options: NSStringDrawingOptions.UsesLineFragmentOrigin, |
There was a problem hiding this comment.
Also NSStringDrawingOptions could be dropped.
|
Hey @RamonGilabert, Sorry for the indentation, Swiftmat was messing with my code. |
Computes Murmur's height dynamically
|
Should be good now! 👍 Nice work @acadet, we'll make a release soon to include this into a wiki. Thank's for the pull request and again sorry about the late responses, been a crazy week. Keep them coming! :) Ramon |
|
Can we do the same for shouts? |
Relative to this issue