Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/single day range #587

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PhillipChaffee
Copy link

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description

The way the calendar currently works is to always return the start and end dates of a range with the time 00:00:00.

I think it is more intuitive to return the end date with a time of 23:59:59. Users would expect the end date they selected to be included in the range.

This would fix this issue and make the calendar more intuitive IMO.

Related Issue: #546

@ImDmj
Copy link

ImDmj commented Aug 19, 2024

@PhillipChaffee is this issue fixed? the PR is still open and has conflicts i see.
can you get this fix deployed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants