Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix pedals #69

Merged
merged 10 commits into from
Apr 11, 2024
Merged

Hotfix pedals #69

merged 10 commits into from
Apr 11, 2024

Conversation

RCMast3r
Copy link
Collaborator

  • fixed pedals once and added tests for both double and single pedal sensor mode
  • fixed issue where car would de-latch when mc error reset would be pressed (println skill issue)

walkermburns
walkermburns reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@walkermburns walkermburns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also thoroughly comment this code or have someone do it

lib/systems/src/PedalsSystem.cpp Outdated Show resolved Hide resolved
@walkermburns walkermburns merged commit d5f106a into master Apr 11, 2024
2 checks passed
@RCMast3r RCMast3r deleted the hotfix_pedals branch April 11, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walkermburns walkermburns walkermburns left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RCMast3r @walkermburns