-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lab 1 done #42
base: main
Are you sure you want to change the base?
lab 1 done #42
Conversation
Finished lab 2 part 1, and fixed changes |
Finished lab 2 part 2 |
finished lab 2 part 3 for review |
AnujNaik/.vscode/settings.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please do not push up your .vscode folder
@@ -0,0 +1,9 @@ | |||
#include <part2.h> | |||
// #include "../include/part2.h" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please dont push commented code
{ stdenv, cmake }: | ||
|
||
stdenv.mkDerivation rec { | ||
pname = "easy_cmake"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the name of this
@@ -0,0 +1,55 @@ | |||
{ | |||
description = "vectornav c++ library"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please change the name
inputs = { | ||
nixpkgs.url = "github:NixOS/nixpkgs/nixos-23.05"; | ||
utils.url = "github:numtide/flake-utils"; | ||
easy_cmake.url = "github:RCMast3r/easy_cmake"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for easy cmake
# include(GNUInstallDirs) | ||
# install(TARGETS hellolib | ||
# EXPORT hellolibTargets | ||
# LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
# ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
# RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} | ||
# PUBLIC_HEADER DESTINATION include | ||
# ) | ||
|
||
# # NAMESPACE sets the namespace that your target will live within. | ||
# # you can have multiple targets under the same namespace | ||
# install(EXPORT hellolibTargets | ||
# FILE hellolibTargets.cmake | ||
# NAMESPACE hellolib:: | ||
# DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/hellolib | ||
# ) | ||
|
||
# # this looks for your .cmake.in file that you created in step 1. | ||
# # if you set the directory differently you may need to handle this differently | ||
# include(CMakePackageConfigHelpers) | ||
# configure_package_config_file(${CMAKE_CURRENT_LIST_DIR}/cmake/hellolibConfig.cmake.in | ||
# "${CMAKE_CURRENT_BINARY_DIR}/hellolibConfig.cmake" | ||
# INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/hellolib | ||
# ) | ||
|
||
# install(FILES | ||
# "${CMAKE_CURRENT_BINARY_DIR}/hellolibConfig.cmake" | ||
# DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/hellolib | ||
# ) | ||
|
||
# # actually install your header files | ||
# install( | ||
# DIRECTORY include/ | ||
# DESTINATION ${CMAKE_INSTALL_PREFIX}/include | ||
# FILES_MATCHING PATTERN "*.h*" | ||
# ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment about pushing commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please dont push the result symlink
# include(GNUInstallDirs) | ||
# install(TARGETS hellolib | ||
# EXPORT hellolibTargets | ||
# LIBRARY DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
# ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR} | ||
# RUNTIME DESTINATION ${CMAKE_INSTALL_BINDIR} | ||
# PUBLIC_HEADER DESTINATION include | ||
# ) | ||
|
||
# # NAMESPACE sets the namespace that your target will live within. | ||
# # you can have multiple targets under the same namespace | ||
# install(EXPORT hellolibTargets | ||
# FILE hellolibTargets.cmake | ||
# NAMESPACE hellolib:: | ||
# DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/hellolib | ||
# ) | ||
|
||
# # this looks for your .cmake.in file that you created in step 1. | ||
# # if you set the directory differently you may need to handle this differently | ||
# include(CMakePackageConfigHelpers) | ||
# configure_package_config_file(${CMAKE_CURRENT_LIST_DIR}/cmake/hellolibConfig.cmake.in | ||
# "${CMAKE_CURRENT_BINARY_DIR}/hellolibConfig.cmake" | ||
# INSTALL_DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/hellolib | ||
# ) | ||
|
||
# install(FILES | ||
# "${CMAKE_CURRENT_BINARY_DIR}/hellolibConfig.cmake" | ||
# DESTINATION ${CMAKE_INSTALL_LIBDIR}/cmake/hellolib | ||
# ) | ||
|
||
# # actually install your header files | ||
# install( | ||
# DIRECTORY include/ | ||
# DESTINATION ${CMAKE_INSTALL_PREFIX}/include | ||
# FILES_MATCHING PATTERN "*.h*" | ||
# ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment about pushing commented code
#for the dev shell -nix develop | ||
# devShells.aarch64-darwin.default = | ||
# pkgs.mkShell rec { | ||
# # Update the name to something that suites your project. | ||
# name = "anuj's main"; | ||
# packages = with pkgs; [ | ||
# # Development Tools | ||
# cmake | ||
# target | ||
# ]; | ||
|
||
# # Setting up the environment variables you need during | ||
# # development. | ||
# shellHook = | ||
# let | ||
# icon = "f121"; | ||
# in | ||
# '' | ||
# echo "hello mom" | ||
# export PS1="$(echo -e '\u${icon}') {\[$(tput sgr0)\]\[\033[38;5;228m\]\w\[$(tput sgr0)\]\[\033[38;5;15m\]} (${name}) \\$ \[$(tput sgr0)\]" | ||
# ''; | ||
# }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see commented about pushing commented code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pls no push symlink
This is my lab 1 and my first pull request.